BUG: Fix query doesn't support equals or not equals with Python parse… #40563
Conversation
|
Could some of the pandas maintainers let me know if the failed checks are normal ? They are unrelated to any changes I've made as far as I know. |
If you look at the failures in a run like https://github.com/pandas-dev/pandas/pull/40563/checks?check_run_id=2163292906, looks like they might be related? |
|
They look related to me. Do these tests pass for you locally? |
| engine, parser = self.engine, self.parser | ||
| df = DataFrame({"x": np.random.choice(["A", "B", "C"], size=20)}) | ||
| tm.assert_frame_equal( | ||
| df.query("x == 'A'", engine=engine, parser=parser), df[df.x == "A"] |
There was a problem hiding this comment.
don't write compound asserts, use
result=
expected=
tm.assert_frame_equal(result, expected)
I understand that my changes had a broader impact than I had anticipated. Some of these tests hard coded the == and != operators as NotImplemented, which I have undone and this is causing them to fail. Will have to really dig around to understand if these changes I made are ok but simply failing tests which should be amended or if I may be introducing some bug(s). Will take much more time than anticipated. |
|
Ok, I dug further into this and I both understand more and less about the issue. I now understand that both the However, I do not understand why Could someone please educate me as to why this is desirable ? |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
would take this if you can merge master and will look again |
|
Thanks for the PR, but it appears to have gone stale. If interested in continuing, please merge master and a maintainer can have a second look. |
…r (#40436)